Hello Laxman, On 06/15/2016 10:13 AM, Laxman Dewangan wrote: > Maxim has used the same clock IP on multiple PMICs like > MAX77686, MAX77802, MAX77620. Only differences are the > number of clocks from these PMICs. > > Add clock binding details and example for the max77620 in > maxim,max77686. > > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > CC: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > CC: Javier Martinez Canillas <javier@xxxxxxxxxxxx> > --- > .../devicetree/bindings/clock/maxim,max77686.txt | 38 +++++++++++++++++++--- > include/dt-bindings/mfd/max77620.h | 4 +++ [snip] > + }; > diff --git a/include/dt-bindings/mfd/max77620.h b/include/dt-bindings/mfd/max77620.h > index b911a07..e1bd08c 100644 > --- a/include/dt-bindings/mfd/max77620.h > +++ b/include/dt-bindings/mfd/max77620.h > @@ -36,4 +36,8 @@ > #define MAX77620_FPS_SRC_NONE 3 > #define MAX77620_FPS_SRC_DEF 4 > > +/* MAX77686 clocks */ > +#define MAX77620_CLKS_NUM 1 > +#define MAX77620_CLK_32K_OUT0 0 > + > #endif > The clocks for the other Maxim PMICs define their clocks in the clock subdir instead, so I wonder if include/dt-bindings/clock/maxim,max77620.h wouldn't be better for consistency? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html