Hello Laxman, On 06/15/2016 10:13 AM, Laxman Dewangan wrote: > The clock driver for Maxim PMICs max77686 and max77802 are > combined into single file to extend the support for same clock > IP for different PMICs. > The DT binding docs shouldn't neither refer to drivers nor map the file structure of the Linux drivers. That's just an implementation detail of Linux and it could be different in other operating systems, the binding should only describe the hardware. So the commit message should explain the benefits of merging the two DT bindings docs without mentioning the Linux driver implementation. > Remove the separate DT binding document file for maxim,max77802 and > move all information to maxim,max77686 DT binding document. > Now, I wonder if this is the correct approach. A system integrator is probably going to search for the bindings of the chip that is present in their system. For example there are different DT bindings docs for both the max77686 and max77802 PMIC even when support is implemented by the same driver (drivers/mfd/max77686.c). But maybe I'm wrong so I'll let people with more DT experience to say if merging the bindings docs in a single one is the correct approach. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
