Hi, On 13/06/2016 15:04, Chen-Yu Tsai wrote: > Hi, > > On Mon, Jun 13, 2016 at 6:15 PM, Quentin Schulz > <quentin.schulz@xxxxxxxxxxxxxxxxxx> wrote: >> The Parrot Board is an evaluation board with an Allwinner R16 (assumed >> to be close to an Allwinner A33), 4GB of NAND, 512MB of RAM, USB host > > You say NAND here, but you enable mmc2 for eMMC below. Please correct it. > ACK. >> and OTG, a WiFi/Bluetooth combo chip, a micro SD Card reader, 2 >> controllable buttons, an LVDS port with separated backlight and >> capacitive touch panel ports, an audio/microphone jack, a camera CSI >> port, 2 sets of 22 GPIOs and an accelerometer. > > I assume the board is this one: > > https://world.taobao.com/item/530374411673.htm > Definitely looks like it. >> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/sun8i-r16-parrot.dts | 333 +++++++++++++++++++++++++++++++++ >> 2 files changed, 334 insertions(+) >> create mode 100644 arch/arm/boot/dts/sun8i-r16-parrot.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 06b6c2d..1149512 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -760,6 +760,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ >> sun8i-a33-ippo-q8h-v1.2.dtb \ >> sun8i-a33-q8-tablet.dtb \ >> sun8i-a33-sinlinx-sina33.dtb \ >> + sun8i-r16-parrot.dtb \ >> sun8i-a83t-allwinner-h8homlet-v2.dtb \ >> sun8i-a83t-cubietruck-plus.dtb \ >> sun8i-h3-orangepi-2.dtb \ >> diff --git a/arch/arm/boot/dts/sun8i-r16-parrot.dts b/arch/arm/boot/dts/sun8i-r16-parrot.dts >> new file mode 100644 >> index 0000000..75e2420 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun8i-r16-parrot.dts >> @@ -0,0 +1,333 @@ >> +/* >> + * Copyright 2015 Quentin Schulz >> + * >> + * Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxx> >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +/dts-v1/; >> +#include "sun8i-a33.dtsi" >> +#include "sunxi-common-regulators.dtsi" >> + >> +#include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/input/input.h> >> + >> +/ { >> + model = "Allwinner Parrot EVB R16"; >> + compatible = "allwinner,parrot-evb-r16", "allwinner,sun8i-a33"; >> + >> + aliases { >> + serial0 = &uart0; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + leds { >> + compatible = "gpio-leds"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&led_pins_r16>; > > IMO r16 is too generic. You may want to add parrot_ or parrot_evb_ to it. > Same goes for all the other r16 identifier names. > ACK. >> + >> + led1 { >> + label = "r16:led1:usr"; >> + gpio = <&pio 4 17 GPIO_ACTIVE_HIGH>; /* PE17 */ >> + }; >> + >> + led2 { >> + label = "r16:led2:usr"; >> + gpio = <&pio 4 16 GPIO_ACTIVE_HIGH>; /* PE16 */ >> + }; >> + }; >> + >> + wifi_pwrseq: wifi_pwrseq { >> + compatible = "mmc-pwrseq-simple"; >> + reset-gpios = <&r_pio 0 6 GPIO_ACTIVE_LOW>; /* PL06 */ >> + }; >> + >> +}; >> + >> +&ehci0 { >> + status = "okay"; >> +}; >> + >> +&i2c1 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c1_pins_a>; >> + status = "okay"; > > Nothing connected? A comment mentioning which connector this is on > if it's not directly connecting something on the board would be nice. > An accelerometer is connected to this i2c, but: 1) The given address of the i2c device given by i2cdetect is not the same as specified in both fex and schematics. 2) The accelerometer has a "product reference" on the schematics for a Broadcom BMA250 but the associated driver does not work with it. So there is an accelerometer connected to this i2c but I've not found yet what can drive it. I could add a comment specifying the accelerometer is attached to this i2c or remove the node? >> +}; >> + >> +&lradc { >> + vref-supply = <®_aldo3>; >> + status = "okay"; >> + >> + button@0 { >> + label = "V+"; >> + linux,code = <KEY_VOLUMEUP>; >> + channel = <0>; >> + voltage = <190000>; >> + }; >> + >> + button@1 { >> + label = "V-"; >> + linux,code = <KEY_VOLUMEDOWN>; >> + channel = <0>; >> + voltage = <390000>; >> + }; >> + >> +}; >> + >> +&mmc0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin_parrot>; >> + vmmc-supply = <®_dcdc1>; >> + cd-gpios = <&pio 3 14 GPIO_ACTIVE_LOW>; /* PD14 */ >> + bus-width = <4>; >> + status = "okay"; >> +}; >> + >> +&mmc1 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&mmc1_pins_a>, <&wifi_reset_pin_r16>; >> + vmmc-supply = <®_aldo1>; > > This looks fishy. See below. > >> + mmc-pwrseq = <&wifi_pwrseq>; >> + bus-width = <4>; >> + non-removable; >> + status = "okay"; >> +}; >> + >> +&mmc2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&mmc2_8bit_pins>; >> + vmmc-supply = <®_dcdc1>; >> + bus-width = <8>; >> + non-removable; >> + cap-mmc-hw-reset; >> + status = "okay"; >> +}; >> + >> +&mmc2_8bit_pins { >> + allwinner,drive = <SUN4I_PINCTRL_40_MA>; >> + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; >> +}; >> + >> +&ohci0 { >> + status = "okay"; >> +}; >> + >> +&pio { >> + mmc0_cd_pin_parrot: mmc0_cd_pin@0 { > > _parrot suffix works as well. > >> + allwinner,pins = "PD14"; >> + allwinner,function = "gpio_in"; >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; >> + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; >> + }; >> + >> + led_pins_r16: led_pins@0 { >> + allwinner,pins = "PE16", "PE17"; >> + allwinner,function = "gpio_out"; >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; >> + }; >> + >> + usb0_id_det: usb0_id_detect_pin@0 { >> + allwinner,pins = "PD10"; >> + allwinner,function = "gpio_in"; >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; >> + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; >> + }; >> + >> + usb1_vbus_pin_r16: usb1_vbus_pin@0 { >> + allwinner,pins = "PD12"; >> + allwinner,function = "gpio_out"; >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; >> + }; >> +}; >> + >> +&r_pio { >> + wifi_reset_pin_r16: wifi_reset_pin@3 { > > Why @3? > This is a typo, I'll correct it. >> + allwinner,pins = "PL6"; >> + allwinner,function = "gpio_out"; >> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; >> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; >> + }; >> +}; >> + >> +&r_rsb { >> + status = "okay"; >> + >> + axp22x: pmic@3a3 { >> + compatible = "x-powers,axp223"; >> + reg = <0x3a3>; >> + interrupt-parent = <&nmi_intc>; >> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; >> + eldoin-supply = <®_dcdc1>; > > A drivevbus-supply referencing reg_vcc5v0 here would be better. > ACK. >> + x-powers,drive-vbus-en; >> + }; >> +}; >> + >> +#include "axp22x.dtsi" >> + >> +®_aldo1 { >> + regulator-always-on; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "aldo1"; > > What is this for exactly? Would turning it off render the system inoperable? > How was it referenced in the fex file? > > If this is for WiFi I/O VCC, then you should specify it in mmc1 with > vqmmc-supply. > In the fex, aldo1 is one of the three power inputs for the WiFi (the others being dldo1 and dldo2) and in the schematics it is linked to both VCC-USB and VCC-IO-WIFI. I tried to turn it off and, indeed, the system becomes inoperable. I'll add vqmmc-supply in mmc1 with aldo1 regulator. However, I am wondering what to put in vmmc-supply for mmc1 since the WiFi module has three power inputs: dldo1, dldo2 and aldo1. In the fex, they are referenced as, respectively, module_power1, module_power2 and module_power3 and in the schematics dldo1 and dldo2 are named VCC-WIFI while aldo1 is used for VCC-IO-WIFI (if it can help in any way). VCC-WIFI is connected to pin VBAT of the Broadcom AP6212 WiFi chip. VCC-IO-WIFI is connected to pin VDDIO of the chip. >> +}; >> + >> +®_aldo2 { >> + regulator-always-on; >> + regulator-min-microvolt = <2350000>; >> + regulator-max-microvolt = <2650000>; >> + regulator-name = "vdd-dll"; >> +}; >> + >> +®_aldo3 { >> + regulator-always-on; >> + regulator-min-microvolt = <2700000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-name = "vcc-pll-avcc"; >> +}; >> + >> +®_dc5ldo { >> + regulator-always-on; >> + regulator-min-microvolt = <900000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-cpus"; >> +}; >> + >> +®_dcdc1 { >> + regulator-always-on; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "vcc-3v0"; >> +}; >> + >> +®_dcdc2 { >> + regulator-always-on; >> + regulator-min-microvolt = <900000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-sys"; >> +}; >> + >> +®_dcdc3 { >> + regulator-always-on; >> + regulator-min-microvolt = <900000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-cpu"; >> +}; >> + >> +®_dcdc5 { >> + regulator-always-on; >> + regulator-min-microvolt = <1500000>; >> + regulator-max-microvolt = <1500000>; >> + regulator-name = "vcc-dram"; >> +}; >> + >> +®_dldo1 { >> + regulator-always-on; > > A comment saying why this is always on would be nice. > I assume this is and dldo2 are waiting on regulator supply list support. > dldo1 and dldo2 are not always on. It is a mistake on my side. Certainly left after quick debugging sessions for the WiFi. >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-name = "vcc-wifi"; >> +}; >> + >> +®_dldo2 { >> + regulator-always-on; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-name = "vcc-wifi1"; >> +}; >> + >> +®_dldo3 { >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "vcc-3v0-csi"; >> +}; >> + >> +®_drivevbus { >> + regulator-name = "usb0-vbus"; >> + status = "okay"; >> +}; >> + >> +®_eldo1 { >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-name = "vcc-1v2-hsic"; >> +}; >> + >> +®_eldo2 { >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "dsp-vcc"; >> +}; >> + >> +®_eldo3 { >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "eldo3"; > > Is this connected or used? If not you could just omit it. > eldo3 is connected to a single GPIO. >> +}; >> + >> +®_usb1_vbus { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&usb1_vbus_pin_r16>; >> + gpio = <&pio 3 12 GPIO_ACTIVE_HIGH>; /* PD12 */ >> + status = "okay"; >> +}; >> + >> +&uart0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart0_pins_b>; >> + status = "okay"; >> +}; >> + >> +&usb_otg { >> + dr_mode = "otg"; >> + status = "okay"; >> +}; >> + >> +&usbphy { >> + status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&usb0_id_det>; >> + usb0_vbus-supply = <®_drivevbus>; >> + usb0_id_det-gpios = <&pio 3 10 GPIO_ACTIVE_HIGH>; /* PD10 */ > > No vbus detect or vbus-power-supply? Though IIRC it still works, just slower. > Adding "usb0_vbus_power-supply = <&usb_power_suply>;" (and setting status of usb_power_supply to okay) makes the micro USB port not detecting USB cable plugged in (in host or peripheral mode). In the fex, the vbus_det-gpio is "apx_ctrl", I guess this means we don't have a GPIO for vbus detection? Thanks! Regards, Quentin > Regards, > ChenYu > >> + usb1_vbus-supply = <®_usb1_vbus>; /* USB1 VBUS is always on */ >> +}; >> -- >> 2.5.0 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
