Hi Yakir, On 8 June 2016 at 12:52, Yakir Yang <ykk@xxxxxxxxxxxxxx> wrote: > The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel > connected using eDP interfaces. > > Signed-off-by: Yakir Yang <ykk@xxxxxxxxxxxxxx> > --- > Changes in v2: None > > drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 3a7bdf1..41020e1 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = { > }, > }; > > +static const struct drm_display_mode lg_lp097qx1_spa1_mode = { I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1. > +static const struct panel_desc lg_lp097qx1_spa1 = { > + .modes = &lg_lp097qx1_spa1_mode, > + .num_modes = 1, > + .size = { > + .width = 2048, > + .height = 1536, These are the physical dimensions of the panel. From the documentation (at the top of the file) @width: width (in millimeters) of the panel's active display area ... Thierry, perhaps it's worth renaming 'size' it to "physical_{size,dimensions}" and/or alike to make it clearer ? Looks like we have a few cases were people got confused - innolux_zj070na_01p and samsung_ltn101nt05. Regards, Emil -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html