On Thu, Nov 21, 2013 at 01:49 +0100, Arnd Bergmann wrote: > > On Wednesday 20 November 2013, Gerhard Sittig wrote: > > re-format and re-word the device tree binding documentation for MPC8xxx > > and compatibles, reference the common document for interrupt controllers > > and remove outdated duplicate SoC specific information > > > > Cc: Mark Rutland <mark.rutland@xxxxxxx> > > Cc: Rob Herring@ <rob.herring@xxxxxxxxxxx> > > Cc: Pawel Moll <Pawel.Moll@xxxxxxx> > > Cc: Arnd Bergmann <arnd@xxxxxxxx> > > Cc: <devicetree@xxxxxxxxxxxxxxx> > > Signed-off-by: Gerhard Sittig <gsi@xxxxxxx> > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> thank you for the feedback and for the ACK > > +Optional properties: > > +- interrupt-controller: Empty boolean property which marks the GPIO > > + module as an IRQ controller. > > +- #interrupt-cells: Number of integer cells required to specify an > > + interrupt within this interrupt controller. The > > + first cell defines the pin number, the second > > + cell defines additional flags (trigger type, > > + trigger polarity). Note that the specific set > > + of trigger conditions supported by the GPIO > > + module depends on the actual SoC. > > Nitpicking: I think you need to add that #interrupt-cells must be <2> > if present. I'd also suggest adding these two to the example section > of the binding while you're at it. will do and I assume that your ACK still applies after I have addressed the feedback from you and from Rob virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@xxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
