On Tue, May 31, 2016 at 11:00:05PM -0700, Hoan Tran wrote: > Hi Guenter, > > > > > Overall, I have to say that the code is quite complex due to the repeated > > checks for ACPI. I am close to suggest having two separate drivers, > > one for ACPI and one for non-ACPI. Any chance to separate ACPI vs. non-ACPI > > code a bit better ? > > How about create separate rx_cb functions for ACPI and non-ACPI ? Yes, that would be great if it is possible. > As almost functions are the same between ACPI and non-ACPI, I thought > keep the same driver is still OK, isn't it ? > If you can separate the ACPI code from the non-ACPI code a bit better than right now, yes. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
