Hi Sergei, On Wed, Jun 1, 2016 at 2:16 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 6/1/2016 11:22 AM, Geert Uytterhoeven wrote: >>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts >>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts >> >>> + ethernet@18000000 { >>> + compatible = "smsc,lan89218", "smsc,lan9115"; >> >> >> The "smsc,lan89218" needs to be documented in the device tree bindings. > > Have you looked at those bindings? Now I did. >> Google couldn't find any evidence you submitted a patch for that. > > Because the bindings document *any* LAN9115 compatible chip already. Ah, generic wildcard, not listing valid values. Hence checkpatch complained... Google predict-while-you-type suggests "lan89218aq"? Should you use that? BTW, that's why we always want to document all valid values... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html