On Tue, May 31, 2016 at 02:24:50PM -0400, George G. Davis wrote: > Hello Fabio, > > On Tue, May 31, 2016 at 02:26:54PM -0300, Fabio Estevam wrote: > > On Tue, May 31, 2016 at 2:17 PM, George G. Davis > > <george_davis@xxxxxxxxxx> wrote: > > > Convert the i.MX FEC driver and DT files to use the GPIOD API > > > which automatically handles GPIO polarity. > > > > > > Signed-off-by: George G. Davis <george_davis@xxxxxxxxxx> > > > > In order to avoid breaking old dtb's a property called > > 'phy-reset-active-high' has been introduced. > > > > Check: 962d8cdc3133435a ("net: fec: Rename "phy-reset-active-low" > > property") and 64f10f6ebf5a6d3ae ("net: fec: Add > > "phy-reset-active-low" property to DT"). > > The GPIOD API handles GPIO active assertion levels as defined by the > DT binding. So the phy-reset-active-high and/or phy-reset-active-low > property is not needed when using the GPIOD API - just define > GPIO_ACTIVE_LOW or GPIO_ACTIVE_HIGH as required for the board and the > GPIOD API will handle active assert/deassert level as needed. You must retain compatibility with _existing_ DT files. Hence, while you can convert to using the gpiod API, you still need to be compatible with the old way of specifying this - iow, you must support the old properties in the code. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html