Hi,
Minor nit, but please put the binding earlier in the series than the
code implementing it, as per
Documentation/devicetree/bindings/submitting-patches.txt
This makes it possible to review a series in a linear fashion.
On Mon, May 23, 2016 at 06:30:24PM +0200, Carlo Caione wrote:
> From: Carlo Caione <carlo@xxxxxxxxxxxx>
>
> Add the binding documentation for the Amlogic secure monitor driver.
>
> Signed-off-by: Carlo Caione <carlo@xxxxxxxxxxxx>
> ---
> .../bindings/firmware/meson/meson_sm.txt | 51 ++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/firmware/meson/meson_sm.txt
>
> diff --git a/Documentation/devicetree/bindings/firmware/meson/meson_sm.txt b/Documentation/devicetree/bindings/firmware/meson/meson_sm.txt
> new file mode 100644
> index 0000000..2b71716
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/meson/meson_sm.txt
> @@ -0,0 +1,51 @@
> +* Amlogic Secure Monitor
> +
> +In the Amlogic SoCs the Secure Monitor code is used to provide access to the
> +NVMEM, enable JTAG, set USB boot, etc...
> +
> +Required properties for the secure monitor node:
> +- compatible: Should be "amlogic,meson-sm"
> +- amlogic,sm-cmd-input-base: SMC32 function identifier to read the physical
> + address of the input buffer
> +- amlogic,sm-cmd-output-base: SMC32 function identifier to read the physical
> + address of the output buffer
Do the IDs for these actually differ per board?
Are some functions simply not implemented on some boards?
> +
> +Example:
> +
> + #include <dt-bindings/firmware/meson-gxbb-sm.h>
> +
> + ...
> +
> + firmware {
> + compatible = "simple-bus";
> +
> + sm: secure-monitor {
> + compatible = "amlogic,meson-sm";
> + amlogic,sm-cmd-input-base = <SM_GET_SHARE_MEM_INPUT_BASE>;
> + amlogic,sm-cmd-output-base = <SM_GET_SHARE_MEM_OUTPUT_BASE>;
> + };
> + };
> +
> +Node of a device using the secure monitor must have a custom property to
> +specify the SMC32 function the driver is going to use. The values of all the
> +SMC function identifiers are listed in a SoC-specific header file:
> +
> +"include/dt-bindings/firmware/meson-gxbb-sm.h" - for the Meson GXBB secure monitor.
> +
> +Example of the node using the secure monitor:
> +
> + #include <dt-bindings/firmware/meson-gxbb-sm.h>
> +
> + ...
> +
> + efuse: efuse {
> + compatible = "amlogic,meson-gxbb-efuse";
> + secure-monitor = <&sm>;
> + amlogic,sm-cmd-read-efuse = <SM_EFUSE_READ>;
> + amlogic,sm-cmd-max-efuse = <SM_EFUSE_USER_MAX>;
Likewise for these?
Mark.
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + ...
> + };
> +
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
