On Tue, Nov 19, 2013 at 12:27:01PM -0700, Stephen Warren wrote: > On 11/19/2013 11:52 AM, Russell King - ARM Linux wrote: > > The installation should just copy the blobs to a path in the filesystem > > _or_ allow a distro to hook into the installation process, just like we > > provide for the installation of the zImage. That is our job done. We > > should do *nothing* more. > > OK, if you're arguing that there should be absolutely zero renaming at > all under any circumstances, I'm fine with that. That's what I'm arguing for. Consider what happens when we need to identify a specific DT blob to be used for a board: "For the Zynteknology Amazingboard, you need to use the DT file imx6dl-amazingboard.dtb". What happens if we have an installation system which renames the files? "For the Zynteknology Amazingboard, you need to use the DT file imx6dl-amazingboard.dtb, but this may also be named zynteknology,amazingboard.dtb on installation". Now, the user has to work out which of two filenames instead of just one, and it becomes a lot harder - it's not difficult for _us_ developers, but from the user point of view, it is, because there is now two things they have to deal with, and a greater chance of making an error. Now, as for using the compatible strings, if you look at the email I just sent previously, I've shown why naming DT blobs by their compatible string is a stupid thing to do. I'll go further: it's an idiotic thing which can't work. We already have DT blobs which contain a _range_ of compatible strings. Does that mean we always choose the first compatible string? If you're using that to match up a DT blob, you've just failed because what if your platform needs to match against the second compatible string? Use symlinks for all compatible strings? Well, what if you have two DT blobs which contain the same compatible string? Yes, we do have lots which fall into this case already. Hence, naming files by compatible string _can't_ ever work sanely. It assumes that compatible strings are unique. They plainly aren't. So, I think we keep the existing naming scheme and just copy the files as is to the installation location. Anything more than that is a "distro" choice - if a distro wants to offer the user a list of DT images to use, the distro needs a tool which parses the compatible strings, works out which of the files match the target, and present the user with that choice - because we already have the case where there is no 1:1 relationship between files and board. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
