On Mon, 18 Nov 2013 15:54:26 -0700, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 11/18/2013 02:21 PM, Jason Cooper wrote: > > In order for 'make dtbs_install' to be maintainable, we need a reliable > > way to determine the board compatible string for a given dtb. fdtget > > does that easily as written, but currently isn't built by the kernel. > > > diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile > > > +include $(src)/libfdt/Makefile.libfdt > > + > > +fdtget-objs := fdtget.o util.o $(patsubst %, libfdt/%, $(LIBFDT_OBJS)) > > I observe that there's a scripts/dtc/Makefile.dtc that /isn't/ used by > scripts/dtc/Makefile. Hence, having scripts/dtc/Makefile use > scripts/dtc/libfdt/Makefile.libfdt seems slightly inconsistent. That > said, it's probably a good idea to use Makefile.libfdt, so perhaps the > answer here is to update Makefile to use Makefile.dtc sometime, rather > than not use Makefile.libfdt in this patch? Perhaps. I'll leave that to another patch is someone wants to take it on. I'm not overly worried though. Applied, thanks. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
