On 05/06/2016 03:44 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote: >> The MFC nodes with the memory regions reserved for memory allocations >> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS. >> >> This causes the s5p-mfc driver probe to fail with the following error: >> >> [ 4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device >> [ 4.216163] s5p-mfc: probe of 11000000.codec failed with error -12 >> >> Add the missing nodes so the driver probes and the {en,de}coder video >> nodes are registered correctly: >> >> [ 4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4 >> [ 4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5 >> >> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >> >> --- >> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index b644858231b6..f9d2e4f1a0e0 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -694,6 +694,11 @@ >> status = "okay"; >> }; >> >> +&mfc { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> +}; >> + >> &mmc_0 { >> status = "okay"; >> num-slots = <1>; >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index 6ba9aec15485..62ceb89e073f 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -669,6 +669,11 @@ >> status = "okay"; >> }; >> >> +&mfc { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> +}; >> + >> &mmc_0 { >> status = "okay"; >> num-slots = <1>; >> > > Any comments about this patch? What is up with the rush now (a week for ping)? As I understand, this was broken for very long time on these boards (since adding DT support in 2012?). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html