Le 05/05/2016 18:04, Grant Grundler a écrit : > On Wed, May 4, 2016 at 6:51 AM, Rob Herring <robh@xxxxxxxxxx> wrote: > ... >>> +Required properties: >>> + >>> + compatible: Must be "atmel,atmegaxx_captouch". >> >> No wildcards in the compatible strings. Use the specific devices. >> >> Also, use hyphen rather than underscore. However, if the device is only >> a touch controller, then '_captouch' is not needed. The part number is >> sufficient to identify the device. > > The primary part used on the board is AtMega88PA. Details of that SoC > are public: > http://www.atmel.com/devices/ATMEGA88PA.aspx > > I don't see why the exact chip is relevant to the driver. The driver > is just talking to an I2C device that reports button events. The > protocol across the I2C determines what this driver has to do and that > protocol is implemented by the on-board firmware (supplied by Atmel). > Any AVR CPU could implement this same protocol. > > Can we call this "atmel,qtouch-buttons-v2" or something like that? Is it different from the Atmel QT1070 or QT2160 which have drivers already available in Linux: drivers/input/keyboard/qt1070.c Bye, > I personally don't have anything invested in any particular name. Feel > free to suggest a different one. I'm perfectly happy with any color > paint on the shed. > > ... >>> +Example: >>> + >>> + atmegaxx_captouch@51 { >> >> atmegaxx@51 (with actual part number) > > Is "qtouch-buttons@51" ok? > >> >>> + compatible = "atmel,atmegaxx_captouch"; >>> + reg = <0x51>; >>> + interrupt-parent = <&tlmm>; >>> + interrupts = <67 IRQ_TYPE_EDGE_FALLING>; >>> + linux,keycodes = <BTN_0>, <BTN_1>, >>> + <BTN_2>, <BTN_3>, >>> + <BTN_4>, <BTN_5>, >>> + <BTN_6>, <BTN_7>; >>> + autorepeat; >>> + }; > > cheers, > grant > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
