On Fri, Nov 15, 2013 at 05:53:56PM +0000, Felipe Balbi wrote: > Hi, > > On Fri, Nov 15, 2013 at 03:55:40PM +0000, Mark Rutland wrote: > > > > > > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > > > > > > > index e1c5300..b61df9d 100644 > > > > > > > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > > > > > > > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > > > > > > > @@ -348,9 +348,16 @@ static int titsc_parse_dt(struct platform_device *pdev, > > > > > > > if (err < 0) > > > > > > > return err; > > > > > > > > > > > > > > - err = of_property_read_u32(node, "ti,coordiante-readouts", > > > > > > > + /* > > > > > > > + * try with new binding first. If it fails, still try with > > > > > > > + * bogus, miss-spelled version. > > > > > > > + */ > > > > > > > + err = of_property_read_u32(node, "ti,coordinate-readouts", > > > > > > > &ts_dev->coordinate_readouts); > > > > > > > if (err < 0) > > > > > > > + err = of_property_read_u32(node, "ti,coordiante-readouts", > > > > > > > + &ts_dev->coordinate_readouts); > > > > > > > + if (err < 0) > > > > > > > return err; > > > > > > > > > > > > Thanks, very good. Do we keep this fallback for ever or just for a year > > > > > > or two? > > > > > > > > > > That's for DT maintainers to decide but considering DT is an ABI, I > > > > > guess we need to keep for 30 years or so :-p > > > > > > > > We keep it as long as we have to. If no-one's relying on the typo by the > > > > next merge window, I see no reason we'd have to keep support for the > > > > > > and how could you know that ? considering it's an ABI, how could you > > > ever know that ? > > > > If you know that the only user of a binding is a dts for a particular > > product that you're in charge of, then you'd know the set of kernel + > > dtb combinations out there, and can judge. > > once the binding has made into mainline, it's next to impossible to > figure out who has downloaded a tarball containing that driver and made > a product out of it. > > Besides keeping that check in the driver won't hurt at all in the long > run. I would give it at least until 4.0 before thinking about removing, > and that might still not be enough time. That sounds sensible to me. As mentioned before I'd recommend adding a warning for the typo now in the (possibly naïve) hope that it will encourage people to fix up their dts early. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
