Re: [PATCH 1/2] input: touchscreen: fix spelling mistake in TSC/ADC DT binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi,

On Tue, Oct 22, 2013 at 10:42:00AM +0200, Sebastian Andrzej Siewior wrote:
> On 10/21/2013 10:13 PM, Felipe Balbi wrote:
> > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> > index e1c5300..b61df9d 100644
> > --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> > @@ -348,9 +348,16 @@ static int titsc_parse_dt(struct platform_device *pdev,
> >  	if (err < 0)
> >  		return err;
> >  
> > -	err = of_property_read_u32(node, "ti,coordiante-readouts",
> > +	/*
> > +	 * try with new binding first. If it fails, still try with
> > +	 * bogus, miss-spelled version.
> > +	 */
> > +	err = of_property_read_u32(node, "ti,coordinate-readouts",
> >  			&ts_dev->coordinate_readouts);
> >  	if (err < 0)
> > +		err = of_property_read_u32(node, "ti,coordiante-readouts",
> > +				&ts_dev->coordinate_readouts);
> > +	if (err < 0)
> >  		return err;
> 
> Thanks, very good. Do we keep this fallback for ever or just for a year
> or two?

That's for DT maintainers to decide but considering DT is an ABI, I
guess we need to keep for 30 years or so :-p

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux