On Sun, Nov 17, 2013 at 07:28:40PM +0100, Pavel Machek wrote: > Hi! > > > On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: > > > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL)) > > > > + keypad_data->no_autorepeat = true; > > > > > > From 2/2: > > > > > > +Optional Properties specific to linux: > > > +- linux,keypad-no-autorepeat: do not enable autorepeat feature. > > > > > > I'm confused now. > > > > good catch! That happens when one tries to mimic other drivers :/ > > > > I just checked all DT input drivers for autorepeat keyword: > > > > DRIVER CODE DOCUMENTATION > > twl4030-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat > > omap4-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat > > samsung-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat > > stmpe-keypad st,no-autorepeat st,no-autorepeat > > spear-keyboard autorepeat autorepeat > > tca8418-keypad keypad,autorepeat --- not documented --- > > gpio-matrix-keypad linux,no-autorepeat linux,no-autorepeat > > gpio-keys-polled autorepeat autorepeat > > gpio-keys autorepeat --- no documentation --- > > > > Any suggestions how to continue fixing this mess? I guess first of > > all the documentation of omap4-keypad, samsung-keypad and of course > > the new twl4030-keypad driver should be fixed. > > > > Next it would be nice to choose one standard property name for this > > and use it for twl4030-keypad. I suggest to use "linux,input-no-autorepeat". > > I'd suggest just simple "autorepeat", so that we get rid of ugly double-negation. The idea was that majority of setups want autorepeat so in the absence of the property autorepeat is turned on. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
