Hi, On Mon, Nov 11, 2013 at 11:19:41PM +0100, Pavel Machek wrote: > > + if (of_get_property(np, "linux,input-no-autorepeat", NULL)) > > + keypad_data->no_autorepeat = true; > > From 2/2: > > +Optional Properties specific to linux: > +- linux,keypad-no-autorepeat: do not enable autorepeat feature. > > I'm confused now. good catch! That happens when one tries to mimic other drivers :/ I just checked all DT input drivers for autorepeat keyword: DRIVER CODE DOCUMENTATION twl4030-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat omap4-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat samsung-keypad linux,input-no-autorepeat linux,keypad-no-autorepeat stmpe-keypad st,no-autorepeat st,no-autorepeat spear-keyboard autorepeat autorepeat tca8418-keypad keypad,autorepeat --- not documented --- gpio-matrix-keypad linux,no-autorepeat linux,no-autorepeat gpio-keys-polled autorepeat autorepeat gpio-keys autorepeat --- no documentation --- Any suggestions how to continue fixing this mess? I guess first of all the documentation of omap4-keypad, samsung-keypad and of course the new twl4030-keypad driver should be fixed. Next it would be nice to choose one standard property name for this and use it for twl4030-keypad. I suggest to use "linux,input-no-autorepeat". -- Sebastian
Attachment:
signature.asc
Description: Digital signature
