Hello, On Mon, 25 Apr 2016 12:28:46 -0500, Bjorn Helgaas wrote: > It *is* pretty trivial. The reason I'm hesitating is because we have > all these DesignWare-based drivers (dra7xx, exynos, imx6, ks, ls, > dw_plat, hisi, qcom, spear13xx, and now armada8k), and they're > *mostly* similar, but they differ in minor, annoying ways. This is > becoming a significant maintenance burden for me, and I'd like to > figure out how to mitigate that. Understood. > For now, I don't have any great ideas except that it would be nice to > remove needless variations. The following is a typical code > structure, but it's not universally followed: > > XXX_pcie_probe > XXX_add_pcie_port > dw_pcie_host_init > XXX_pcie_host_init > dw_pcie_setup_rc > XXX_pcie_establish_link Indeed, the first step towards having more common code is to make the code to be factorized look as similar as possible. > There's a hodge-podge of ways to get related resources (clocks and > PHYs) and initialize them. IRQ setup is not really consistent across > all the drivers. It's sort of disappointing that most of these > drivers have a "dbi_base" resource, but they use different DT property > names for it. > > The armada8k driver doesn't have a DRV_add_pcie_port() function or a > DRV_pcie_establish_link() function, and it has its own "wait for link" > timeout loop instead of using dw_pcie_wait_for_link(). > > How about if you just shuffle those bits around into > an armada8k_add_pcie_port() and an armada8k_pcie_establish_link(), and > we'll call that good for now? I'll take a stab at that tomorrow and send an updated version. Thanks for the feedback! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
