Hi Stefan, On Sa, 2016-04-23 at 09:46 +0200, Stefan Wahren wrote: > Hi, > > i want to add an sram node to arch/arm/boot/dts/imx28.dtsi. According > to > the reference manual [1] the On-Chip RAM is connected to AHB, start > address 0 and has a size of 128 KB. > > So i modified the imx28.dtsi based on the patch below. Unfortunately > the > dtc give me some strang errors: > > ERROR (duplicate_label): Duplicate label 'mac0' on > /ahb@80080000/ethernet@800f0000 and /ahb@00000000/ethernet@800f0000 > ERROR: Input tree has errors, aborting (use -f to force output) > > What's wrong with my patch or does it reveal another issue? > > Regards > Stefan > > [1] - http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.p > df > i.MX28 Applications Processor Reference Manual, Rev. 2, 08/2013 > Chapter 4.1 Memory Map Overview > > -------------------------->8--------------------------------------- > --- a/arch/arm/boot/dts/imx28.dtsi > +++ b/arch/arm/boot/dts/imx28.dtsi > @@ -1311,13 +1311,18 @@ > }; > }; > > - ahb@80080000 { > + ahb@00000000 { > compatible = "simple-bus"; > #address-cells = <1>; > #size-cells = <1>; > - reg = <0x80080000 0x80000>; > + reg = <0x00000000 0x20000>, <0x80080000 0x80000>; > ranges; > > + ocram: sram@00000000 { > + compatible = "mmio-sram"; > + reg = <0x00000000 0x20000>; > + }; > + > usb0: usb@80080000 { > compatible = "fsl,imx28-usb", "fsl,imx27- > usb"; > reg = <0x80080000 0x10000>; Follwing the address map for the i.MX28 (p. 125ff) the AHB is mapped to different start addresses: Bus MNEMONIC START ADDRESS -------------------------------------- AHB OCRAM 0x00000000 AHB USBCTRL0 0x80080000 AHB OCROM 0xC0000000 So instead of replacing ahb@80080000 by ahb@00000000 a new node should be created. However, I am not sure if this is really necessary, I haven't seen it for all device trees using "mmio-sram". Best regards Jörg Krause -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
