On Thu, 14 Nov 2013 15:05:56 +0000, Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> wrote: > According to Documentation/devicetree/bindings/net/phy.txt device_type > property of PHY nodes is mandatory, which should be set to > "ethernet-phy". This patch adds check in scanning phys and only scans > node which have device-type set to "ethernet-phy". > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> Hi Srinivas, Thanks for looking at this. However, there is a high likelyhood that this patch will break existing platforms since we haven't enforced this requirement before. Besides, I don't think the ethernet-phy binding is necessary. The mere fact that it is a child of the MDIO bus node means that the device is a PHY device for the purposes of the subsystem. Nacked-by: Grant Likely <grant.likely@xxxxxxxxxx> g. > --- > drivers/of/of_mdio.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c > index d5a57a9..78c53c7 100644 > --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -57,6 +57,9 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) > > /* Loop over the child nodes and register a phy_device for each one */ > for_each_available_child_of_node(np, child) { > + /* A PHY must have device_type set to "ethernet-phy" */ > + if (of_node_cmp(child->type, "ethernet-phy")) > + continue; > /* A PHY must have a reg property in the range [0-31] */ > paddr = of_get_property(child, "reg", &len); > if (!paddr || len < sizeof(*paddr)) { > @@ -112,6 +115,10 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) > > /* auto scan for PHYs with empty reg property */ > for_each_available_child_of_node(np, child) { > + /* A PHY must have device_type set to "ethernet-phy" */ > + if (of_node_cmp(child->type, "ethernet-phy")) > + continue; > + > /* Skip PHYs with reg property set */ > paddr = of_get_property(child, "reg", &len); > if (paddr) > -- > 1.7.6.5 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html