On Thu, Apr 14, 2016 at 11:47 AM, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote: > Rob Herring wrote: > >>> @@ -0,0 +1,65 @@ >>> +Qualcomm EMAC Gigabit Ethernet Controller >>> + >>> +Required properties: >>> +- compatible : Should be "qcom,emac". >> >> >> Come on... Can you guess what I'm going to say here. > > > Ooops, I missed that one. > >> >>> +- reg : Offset and length of the register regions for the device >>> +- reg-names : Register region names referenced in 'reg' above. >>> + Required register resource entries are: >>> + "base" : EMAC controller base register block. >>> + "csr" : EMAC wrapper register block. >>> + Optional register resource entries are: >>> + "ptp" : EMAC PTP (1588) register block. >>> + Required if 'qcom,emac-tstamp-en' is present. >>> + "sgmii" : EMAC SGMII PHY register block. >>> +- interrupts : Interrupt numbers used by this controller >>> +- interrupt-names : Interrupt resource names referenced in 'interrupts' >>> above. >>> + Required interrupt resource entries are: >>> + "emac_core0" : EMAC core0 interrupt. >>> + "sgmii_irq" : EMAC SGMII interrupt. >>> +- phy-addr : Specifies phy address on MDIO bus. >>> + Required if the optional property >>> "qcom,no-external-phy" >>> + is not specified. >> >> >> As I mentioned in the last version, you should still describe this with >> a standard MDIO bus binding even if you can't use the generic code. > > > You mean like this? > > phy0: ethernet-phy@0 { > compatible = "qcom,fsm9900-emac-phy"; > reg = <4>; Yes, but you mean 0 here or 4 for unit address. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html