Re: [PATCH 2/2] pci: host: new driver for Marvell Armada 7K/8K PCIe controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello,

On Mon, 28 Mar 2016 23:21:57 +0200, Arnd Bergmann wrote:
> On Sunday 27 March 2016 11:30:58 Thomas Petazzoni wrote:
> > +       /* Wait until the link becomes active again */
> > +       while (timeout) {
> > +               if (armada8k_pcie_link_up(pp))
> > +                       break;
> > +               udelay(1);
> > +               timeout--;
> > +       }
> > 
> 
> Why the busy-loop here?
> 
> Maybe just do a single msleep(1) here to wait for the link to
> come up instead?

I've changed the udelay(1) by msleep(1). Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux