Hello, On Fri, 1 Apr 2016 18:27:31 -0700, Stephen Boyd wrote: > > +#include <linux/kernel.h> > > +#include <linux/clk.h> > > Is this used? No, fixed! > > +#include <linux/clk-provider.h> > > +#include <linux/io.h> > > Is this used? Ditto! > > +static void __init ap806_syscon_clk_init(struct device_node *np) > > Can this be a platform driver instead? I've moved to a platform driver, and it seems to work fine. Will be in v5. Thanks for the review! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html