Re: [PATCH 1/7] soc/tegra: pmc: Use BIT macro for register field definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Tuesday 12 April 2016 08:56 PM, Thierry Reding wrote:
* PGP Signed by an unknown key

On Tue, Apr 12, 2016 at 08:26:41PM +0530, Laxman Dewangan wrote:
Use BIT macro for register field definition and make constant as
unsigned when using in shift operator like instead of (3 << 30),
make it to (3U << 30).

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
---
  drivers/soc/tegra/pmc.c | 42 +++++++++++++++++++++---------------------
  1 file changed, 21 insertions(+), 21 deletions(-)
Does this matter at all? We use the explicit notation in quite a number
of places and it works great. I'd like to avoid needless churn unless
there is a very good reason to switch.

When I run the checkpatch, I got the error and thought that better to fix and cleanup some warning/error from checkpatch. This is just part of cleanups and properly defining constant like 3U instead of 3 to avoid any issue.



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux