Hi Rob, > On Wed, Apr 06, 2016 at 07:59:31PM +0530, Sricharan R wrote: > > The driver currently works based on platform data. Remove this and add > > support for DT. A single master can have multiple ports connected to > > more than one iommu. > > > > master > > | > > | > > | > > ------------------------ > > | | > > IOMMU0 IOMMU1 > > You've got mixtures of tabs and spaces here. Either fully use leading tabs or > use spaces everywhere. Ok, will change this properly. > > > | | > > ctx0 ctx1 ctx0 ctx1 > > > > It is preferred to split bindings to separate patch. Ok, will split it. > > +The QCOM IOMMU is an implementation compatible with the ARM VMSA > > +short descriptor page tables. It provides address translation for bus > > +masters outside of the CPU, each connected to the IOMMU through a > port called micro-TLB. > > + > > +Required Properties: > > + > > + - compatible: Must contain "qcom,iommu-v0". > > You need SoC specific compatible strings in addition. > Ok, will add it. Regards, Sricharan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html