On Mon 11 Apr 05:30 PDT 2016, Lee Jones wrote: > On Wed, 30 Mar 2016, Bjorn Andersson wrote: > > > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> > > > > Implement Device Tree parsing functions to support initialization of the > > lm3533 drivers. > > > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > --- > > Changes since v2: > > - Drop vendor prefix of vendor properties > > - Specify unit of various properties > > - Fix reference paths > > > > Changes since v1: > > - Added unit to boost-freq and als-resistance (as the frequency now comes with > > a unit specifier I changed it to be expressed in kHz) > > > > drivers/mfd/lm3533-core.c | 264 ++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 264 insertions(+) > > > > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > > index 5abcbb2e8849..dbf26d86fe85 100644 > > --- a/drivers/mfd/lm3533-core.c > > +++ b/drivers/mfd/lm3533-core.c > > @@ -18,6 +18,7 @@ > > #include <linux/gpio.h> > > #include <linux/i2c.h> > > #include <linux/mfd/core.h> > > +#include <linux/of_gpio.h> > > #include <linux/regmap.h> > > #include <linux/seq_file.h> > > #include <linux/slab.h> > > @@ -25,6 +26,7 @@ > > > > #include <linux/mfd/lm3533.h> > > > > +#define LM3533_DEFAULT_BRIGHTNESS 200 > > The MFD doesn't care about child specifics. These needs to go into > the child driver. > OK, sounds reasonable. Thanks for your feedback! Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
