Re: [PATCH 1/2] thermal: generic-adc: Add DT binding for ADC based thermal sensor driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Eduardo,
Thanks for review.

On Wednesday 06 April 2016 09:31 PM, Eduardo Valentin wrote:
On Wed, Apr 06, 2016 at 03:33:05PM +0530, Laxman Dewangan wrote:
+- step-temperature:	     The temperature steps for the reading ADC
+			     value in millicelsius.
How about when you have a sensor that does not have a nice linear
stepping correlation ?

Here just temp is stepping but ADC reading is not in linear. So temp vs adc value is not linear. Just making the table that temp vs adc value where temp is in equally stepped.

if something is not possible for few steps than that can be intrapolate here to get this.

Other way as you said: two dimensional. You mean <temp ADC-value> pair for the table?

This is also possible and on this case, we will not need lower/upper and step temperature.
Table will provide all the information.

Also, I assume that sensor is negative coefficients. Temp increases->ADC read value decreases.

Should we also support positive coefficient relation?

+			writable;
Not sure about writable property, where is it described?
It is from my testing, not standard.  I will remove it.
+		};
+	};
+
+	cooling-maps {
+		map0 {
+			trip = <&therm_est_trip>;
+			cooling-device = <&dummy_cool_dev THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+			contribution = <100>;
+			cdev-type = "therm_est_activ";

Not sure about cdev-type property, where is it described?
From my testing only. Will remove it.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux