On Fri, Apr 1, 2016 at 9:41 AM, Petr Štetiar <ynezz@xxxxxxx> wrote: > /* Some boards don't have PCIe reset GPIO. */ > if (gpio_is_valid(imx6_pcie->reset_gpio)) { > - gpio_set_value_cansleep(imx6_pcie->reset_gpio, 0); > + gpio_set_value_cansleep(imx6_pcie->reset_gpio, > + !!imx6_pcie->gpio_active_high); gpio_set_value_cansleep(imx6_pcie->reset_gpio, imx6_pcie->gpio_active_high); is enough. > @@ -546,9 +549,14 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) > > /* Fetch GPIOs */ > imx6_pcie->reset_gpio = of_get_named_gpio(np, "reset-gpio", 0); > + imx6_pcie->gpio_active_high = of_property_read_bool(np, > + "reset-gpio-active-high"); You need to document reset-gpio-active-high property in Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html