On Thu, Mar 31, 2016 at 02:44:45PM +0300, Irina Tirdea wrote:
> +static int acpi_parse_gpio_res(struct pinctrl *p,
> + struct pinctrl_map **map,
> + unsigned *num_maps,
> + struct pinctrl_dev ***pctldevs)
> +{
> + struct acpi_gpio_lookup lookup;
> + struct list_head res_list;
> + struct acpi_device *adev;
> + unsigned int index;
> + int ret;
> +
> + adev = ACPI_COMPANION(p->dev);
> +
> + *map = NULL;
> + *num_maps = 0;
> + memset(&lookup, 0, sizeof(lookup));
> +
> + /* Parse all GpioInt/GpioIo resources in _CRS and extract pin conf */
> + for (index = 0; ; index++) {
> + lookup.index = index;
> + lookup.n = 0;
> + lookup.found = false;
> +
> + INIT_LIST_HEAD(&res_list);
> + ret = acpi_dev_get_resources(adev, &res_list, acpi_gpio_to_map,
> + &lookup);
> + if (ret < 0)
> + goto exit_free;
> + acpi_dev_free_resource_list(&res_list);
> + if (!lookup.found)
> + break;
> + }
> +
> + *map = lookup.map;
> + *num_maps = lookup.num_maps;
> + *pctldevs = lookup.pctldevs;
This function has quite many stars in arguments and in the function
body. In particular pctldevs has three stars!
I wonder if this could be written in such way that avoids that. Like
create a structure holding the map information and pass that to the
function instead.
Other parts of the patch look good to me.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
