Hi Rob, On 4/4/2016 6:15 AM, Rob Herring wrote: > On Thu, Mar 31, 2016 at 07:57:21PM +0100, Joao Pinto wrote: >> This patch adds a glue platform driver for the Synopsys G210 Test Chip. >> >> Signed-off-by: Joao Pinto <jpinto@xxxxxxxxxxxx> >> --- [snip] >> + >> +Required properties: >> +- compatible : compatible list must contain the PHY type & version: >> + "snps, g210-tc-6.00-20bit" >> + "snps, g210-tc-6.00-40bit" > Remove the space ^ > >> + complemented with the Controller IP version: >> + "snps, dwc-ufshcd-1.40a" > > ditto Ok, will do that! > > Combining the phy and controller compatible strings is a bit strange. > Generally, they would be separate nodes using the common phy binding. > Correct, but in this case is just the compatibility string is just to tell the dw ufs host that it has a 40-bit or a 20-bit test chip connected. The Test chip is initialized by a unipro command sequence and there is no more ops related to it. >> + complemented with the JEDEC version: >> + "jedec,ufs-1.1" >> + "jedec,ufs-2.0" >> + >> +- reg : <registers mapping> >> +- interrupts : <interrupt mapping for UFS host controller IRQ> >> + >> +Example for a setup using a 1.40a DWC Controller with a 6.00 G210 40-bit TC: >> + dwc_ufs@d0000000 { > > No underscores please. Ok, will update it. > >> + compatible = "snps, g210-tc-6.00-40bit", >> + "snps, dwc-ufshcd-1.40a", >> + "jedec,ufs-2.0"; >> + reg = < 0xd0000000 0x10000 >; >> + interrupts = < 24 >; >> + }; > Will send a v13 with these tweaks. Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html