On 05.03.2016 13:42, pankaj.dubey wrote: > Hi, > > On Wednesday 02 March 2016 11:23 PM, Rob Herring wrote: >> On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote: >>> This patch adds exynos-srom binding information for SROM Controller >>> driver on Exynos SoCs. >>> >>> CC: Rob Herring <robh+dt@xxxxxxxxxx> >>> CC: Mark Rutland <mark.rutland@xxxxxxx> >>> CC: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> >>> CC: devicetree@xxxxxxxxxxxxxxx >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> >>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> >>> Signed-off-by: Kukjin Kim <kgene@xxxxxxxxxx> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/memory-controllers/exynos-srom.txt | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >>> >>> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >>> new file mode 100644 >>> index 0000000..33886d5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt >>> @@ -0,0 +1,12 @@ >>> +SAMSUNG Exynos SoCs SROM Controller driver. >>> + >>> +Required properties: >>> +- compatible : Should contain "samsung,exynos-srom". >> >> There should be SoC specific compatible strings in addition to this. >> > > I do not understood need to additional need to SoC specific compatible, > as of now all SoCs having SROM can work with exynos specific common > compatible. Will you see any issues in this? Dear Rob, Pankaj, I would like to proceed with this patchset. I guess your comment here was about to change the compatible from generic exynos-like to a model specific. How about this: - compatible : Should contain "samsung,exynos4210-srom". Is this okay? (the oldest chip mentioning SROM controller as separate block is Exynos4210) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
