Hi Rafal, On Wed, 23 Mar 2016 11:18:59 +0100 Rafał Miłecki <zajec5@xxxxxxxxx> wrote: > Some time ago I started working on a new "nand-ecc-algo" property to allow > specifying ECC algorithm for hardware ECC mode as well. > Boris pointed out it's becoming a bit messy that way as we already have value > NAND_ECC_SOFT_BCH. > I suggested deprecating "soft_bch" value from nand-ecc-mode property and got > Boris agreed and no objections from others. So there is how I want to implement > this. > If you agree on this way & apply my patches, I'll start modifying NAND drivers > (similarly to the nandsim) and then will try to drop NAND_ECC_SOFT_BCH except > for handling backward compatibility. > Then finally we should be able to add "nand-ecc-algo" property support properly. > > V2: Add of_get_nand_ecc_algo helper (in 2/4) instead of this slightly hacky code > in nand_dt_init that would be replaced anyway. Whole series applied to nand/next [1]. I just added a comment for the ecc->algo field in patch 1. You can continue your rework (patch existing NAND_ECC_SOFT_BCH and NAND_ECC_SOFT users to use ecc->algo). Thanks, Boris [1]https://github.com/linux-nand/linux/tree/nand/next -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html