On Sun, Mar 27, 2016 at 12:50 AM, Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:
> On Wed 23 Mar 12:48 PDT 2016, Srinivas Kandagatla wrote:
>
>> This patch adds support to 4 user leds, wlan and bt led on board.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
>
> I'm not fond of the overly complicated names; and I think it should at
> least be shortened to "db600c:...".
These names are exposed to userspace. They should be the same across
all 96boards. Same goes for UART numbering and I2C bus labels on the
connector.
> Tested this on my DB600c, seems to work, except the WiFi/BT triggers,
> see comments below.
>
>> + leds {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&user_leds>, <&mpp_leds>;
>> +
>> + compatible = "gpio-leds";
>> +
>> + led@1 {
unit-address w/o reg property will warn on new dtc. I'd suggest
something like "userX-led".
>> + label = "dragonboard-600c:green:user1";
>> + gpios = <&tlmm_pinmux 3 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
