Hi Tony, On 18/03/16 15:41, Grygorii Strashko wrote: > On 03/17/2016 04:19 PM, Jon Hunter wrote: >> The ARM TWD interrupt is a private peripheral interrupt (PPI) and per >> the ARM GIC documentation, whether the type for PPIs can be set is >> IMPLEMENTATION DEFINED. For OMAP4 devices the PPI type cannot be set and >> so when we attempt to set the type for the ARM TWD interrupt it fails. >> This has done unnoticed because it fails silently and because we cannot >> re-configure the type it has had no impact. Nevertheless fix the type >> for the TWD interrupt so that it matches the hardware configuration. >> >> Reported-by: Grygorii Strashko <grygorii.strashko@xxxxxx> >> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> >> >> --- >> >> Tony, Grygorii, >> Please note that I have not tested this. Can you test this series and >> see if you see any warnings on OMAP4? I am guessing that the configuration >> should be LEVEL and not EDGE. This was reported here: > > Tested-by: Grygorii Strashko <grygorii.strashko@xxxxxx> > > Tested on PandaBoard. Without this patch I can see below warning: I think that you can pick up this fix independently of this series as it is something that has been broken for sometime and should be fixed. I included it here for completeness to highlight the issue but if you want to take it now, please go ahead. Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
