Hi Geert,
On 29/03/16 14:04, Geert Uytterhoeven wrote:
> Hi Jon,
>
> On Thu, Mar 17, 2016 at 3:19 PM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>> --- a/drivers/irqchip/irq-gic.c
>> +++ b/drivers/irqchip/irq-gic.c
>
>> -#ifdef CONFIG_SMP
>> - set_smp_cross_call(gic_raise_softirq);
>> - register_cpu_notifier(&gic_cpu_notifier);
>> -#endif
>
>
>> + if (gic_nr == 0) {
>> + if (IS_ENABLED(CONFIG_SMP)) {
>> + set_smp_cross_call(gic_raise_softirq);
>
> If CONFIG_SMP=n:
>
> drivers/irqchip/irq-gic.c: In function '__gic_init_bases':
> drivers/irqchip/irq-gic.c:1165:4: error: implicit declaration of
> function 'set_smp_cross_call' [-Werror=implicit-function-declaration]
> set_smp_cross_call(gic_raise_softirq);
> ^
>
> There's no dummy for the CONFIG_SMP=n case, so you either have to
> keep the #ifdef, or add a dummy.
>
>> + register_cpu_notifier(&gic_cpu_notifier);
>> + }
Thanks. I have already fixed this in my tree locally.
Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
