Hello Guenter, On Tue, Mar 29, 2016 at 7:44 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On 03/29/2016 01:50 AM, Joel Stanley wrote: >> >> This adds a of_device_id table so we can probe the driver using the >> device tree. >> > The subject line does not match the driver being modified; it suggests > adm1031 > while in reality the adm1275 driver is being modified. Apologies, that's what I get for writing a patch as I'm walking out the door. > Besides, this should already work, through trivial bindings. > Is there a reason to believe that it does not already work ? I wasn't aware that we had such a mechanism, thank you. I assume you referring to bindings/i2c/trival-devices.txt? As background for why I added the bindings; originally this code was patch one of two. The second added a device tree property to inform the kernel of the external sense resistor so we could perform scaling in the kernel. I read the hwmon documentation on why this is not currently done. However, as the device tree is specific to a board - things like i2c addresses and which bus they are on - I was wondering if you would take patches to add such a feature? Cheers, Joel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
