On Tue, Mar 08, 2016 at 05:25:13PM +0800, Jiancheng Xue wrote: > On 2016/3/8 6:52, Brian Norris wrote: > [...] > >> +static void hisi_spi_nor_dma_transfer(struct spi_nor *nor, u32 start_off, > >> + u32 dma_buf, u32 len, u8 op_type) > > > > Does this controller support 64-bit addresses? What if you see LPAE, or > > an ARM64 CPU? It'd be nice if you don't truncate potentially 64-bit > > dma_buf down to u32. > > > > Brian > > > No, this controller just supports 32-bit addresses. So I think I have to truncate 64-bit dma_buf. :( Then you should handle this proactively. Either some kind of WARN_ON and error condition, or I think dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)) should be able to ensure you get addresses in the appropriate range? Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
