On Monday 11 November 2013 12:10 PM, Khoronzhuk, Ivan wrote: > If Davinci AEMIF is used we don't need to set timings and bus width. > It is done by AEMIF driver (drivers/memory/davinci-aemfi.c). > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxx> > --- > drivers/mtd/nand/davinci_nand.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index 4705214..879e915 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -742,27 +742,35 @@ static int __init nand_davinci_probe(struct platform_device *pdev) > goto err_clk_enable; > } > > +#if !IS_ENABLED(CONFIG_TI_DAVINCI_AEMIF) > Instead above #if, just use a variable. bool aemif = IS_ENABLED(CONFIG_TI_DAVINCI_AEMIF) and then skip the below code. #if block in the middle of the code looks ugly. Other than that patch looks fine to me. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
