On 03/03/2016 01:15 PM, Arnd Bergmann wrote: > On Thursday 03 March 2016 12:40:07 Neil Armstrong wrote: >> + >> + aliases { >> + serial0 = &uart0; >> + serial1 = &uart1; >> + serial2 = &uart2; >> + serial3 = &uart3; >> + gpio0 = &gpio0; >> + gpio1 = &gpio1; >> + }; >> > Please put the aliases in the per-board file and list only the > devices that are actually connected (in case of uart) Done. > >> + uart0: uart@200000 { > > Make this serial@200000, to follow the standard naming convention Done. > >> + >> + reset: reset-controller { >> + compatible = "plxtech,nas782x-reset"; >> + #reset-cells = <1>; >> + }; >> + >> + stdclk: stdclk { >> + compatible = "plxtech,ox810se-stdclk", "plxtech,nas782x-stdclk"; >> + #clock-cells = <1>; >> + }; >> + }; > > Please change the compatible strings to have no 'x' wildcards in them, but > instead use a specific model. Ok, I switched to only oxsemi,ox810se-* strings. > > Regarding the vendor prefixes, my understanding is that "ox810se" was the name > of the chip from Oxford Semiconductor, while nas7820 is a product name from > PLX. I think it would be logical to use "oxford" as the vendor prefix > for anything with a ox810se or ox820 ID in it rather than plxtech. Ok, I switched to oxsemi but keeped plxtech and added oxsemi in the vendor prefixes. > > Note that both of them are now historic, as PLX itself got bought by > Avago and they seem to be discontinuing both the PLX and Oxfor brand > names. Yes, it's kind of a mess. The ox820 has been rebranded to plx7821, but not the ox810... > > Arnd > Thanks, Neil -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html