Hi Joachim, Quoting Joachim Eastwood (2016-02-24 14:04:19) > +static struct clk *clk_register_creg_clk(struct clk_creg_data *creg_clk, > + const char **parent_name, > + struct regmap *syscon) > +{ > + struct clk_init_data init; > + > + init.ops = creg_clk->ops; > + init.name = creg_clk->name; > + init.parent_names = parent_name; > + init.num_parents = 1; > + > + creg_clk->reg = syscon; > + creg_clk->hw.init = &init; > + > + return clk_register(NULL, &creg_clk->hw); This should be devm_clk_register with your struct device *dev passed into it. Otherwise this patch looks good for merge. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html