Hi Geert,
On Friday 26 February 2016 16:41:27 Geert Uytterhoeven wrote:
> On Mon, Feb 15, 2016 at 11:51 PM, Laurent Pinchart wrote:
> >> drivers/soc/renesas/pm-rcar.c | 327 ++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 327 insertions(+)
> >>
> >> diff --git a/drivers/soc/renesas/pm-rcar.c
> >> b/drivers/soc/renesas/pm-rcar.c
> >> index cc684e9cc8db5d1c..c0540934126e58eb 100644
> >> --- a/drivers/soc/renesas/pm-rcar.c
> >> +++ b/drivers/soc/renesas/pm-rcar.c
> >>
> >> +static int __init rcar_init_pm_domains(void)
> >> +{
> >> + const struct of_device_id *match;
> >> + struct device_node *np, *pmd;
> >> + bool scanned = false;
> >> + void __iomem *base;
> >> + int ret = 0;
> >> +
> >> + for_each_matching_node_and_match(np, rcar_sysc_matches, &match) {
> >> + u32 syscier = 0;
> >> +
> >> + rcar_gen = (uintptr_t)match->data;
> >> +
> >> + base = of_iomap(np, 0);
> >> + if (!base) {
> >> + pr_warn("%s cannot map reg 0\n", np->full_name);
> >> + continue;
> >> + }
> >> +
> >> + rcar_sysc_base = base; // FIXME conflicts with
> >> rcar_sysc_init() +
> >> + pmd = of_get_child_by_name(np, "pm-domains");
> >> + if (!pmd) {
> >> + pr_warn("%s lacks pm-domains node\n",
> >> np->full_name);
> >
> > Shouldn't you call iounmap() here ?
>
> Yes. Will fix.
>
> >> + /*
> >> + * Enable all interrupt sources, but do not use interrupt
> >> + * handler
> >> + */
> >> + pr_debug("%s: syscier = 0x%08x\n", np->full_name, syscier);
> >> + iowrite32(syscier, rcar_sysc_base + SYSCIER);
> >> + iowrite32(0, rcar_sysc_base + SYSCIMR);
> >
> > Shouldn't the SYSCIMR bits be set to 1 to mask interrupts ?
>
> That would work, too. It doesn't matter much, as the driver doesn't use
> interrupts, so they stay disabled at the GIC level.
You're right, but as you write to the SYSCIMR register anyway, I'd feel safer
if interrupts were masked in it too.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
