Hi Stephen, On 2016/2/26 7:42, Stephen Boyd wrote: >> diff --git a/drivers/clk/hisilicon/reset.c b/drivers/clk/hisilicon/reset.c >> new file mode 100644 >> index 0000000..50e00e7 >> --- /dev/null >> +++ b/drivers/clk/hisilicon/reset.c >> + >> +int hisi_reset_init(struct device_node *np) >> +{ >> + struct hisi_reset_controller *rstc; >> + >> + rstc = kzalloc(sizeof(*rstc), GFP_KERNEL); >> + if (!rstc) >> + return -ENOMEM; >> + >> + rstc->membase = of_iomap(np, 0); > > Any reason why we can't pass the platform device here and map the > register space with platform device APIs? > This function can be called by other clock drivers except clk-hi3519. Some clock drivers may not be registered as platform drivers. Moreover this function may be called early even before platform_bus_init. Thank you! Regards, Jiancheng. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html