Quoting Joachim Eastwood (2016-02-20 10:53:36) > +static const struct clk_ops clk_creg_32k = { > + .enable = clk_creg_enable, > + .disable = clk_creg_disable, There should be a .is_enabled here. > + .prepare = clk_creg_32k_prepare, > + .unprepare = clk_creg_32k_unprepare, > + .is_prepared = clk_creg_32k_is_prepared, > +}; > + > +static const struct clk_ops clk_creg_1k = { > + .enable = clk_creg_enable, > + .disable = clk_creg_disable, Ditto. Otherwise patch looks good to me. Thanks a lot for all of the rework. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html