Re: [PATCH 2/4] tools: gpio: Add necessary include paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tuesday, February 23, 2016 02:26:09 PM Linus Walleij wrote:
> On Tue, Feb 23, 2016 at 8:54 AM, Markus Pargmann <mpa@xxxxxxxxxxxxxx> wrote:
> 
> > Add include paths to the Makefile so that linux/gpio.h can be found even
> > on systems without this header.
> >
> > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
> (...)
> > -CFLAGS += -Wall -g -D_GNU_SOURCE
> > +CFLAGS += -Wall -g -D_GNU_SOURCE -I ../include -I ../../include/uapi
> 
> This is probably not how userspace compilation is supposed
> to work. The way I understand it, userspace programs from tools/*
> should be compiled like this:
> 
> make headers_install ARCH=foo INSTALL_HDR_PATH=<bar>
> cd tools/gpio
> make CFLAGS="$CFLAGS -I<bar>"
> 
> The reason being that UAPI files can differ after install depending
> on arch.

I see, thanks for explaining.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux