Hi, On 15/02/16 14:58, Chen-Yu Tsai wrote: > On Mon, Feb 15, 2016 at 10:36 PM, Andre Przywara <andre.przywara@xxxxxxx> wrote: >> Hi Chen-Yu, >> >> On 15/02/16 14:23, Chen-Yu Tsai wrote: >>> On Mon, Feb 15, 2016 at 9:59 PM, Andre Przywara <andre.przywara@xxxxxxx> wrote: >>>> Hi Hans, >>>> >>>> .... >>>> >>>>> >>>>> p.s. >>>>> >>>>> I love the work you've been doing on the A64, I've not had a chance >>>>> to try it out yet though. Have you made any progress with getting >>>>> the mmc slot to work ? If not maybe I can make some time I've >>>>> prior experience in bringing up the mmc slot on other Allwinner SoCs >>>> >>>> Thanks for that! >>>> >>>> So we made some progress on the weekend (with the help of #linux-sunxi): >>>> 1) The regulator node was stupidly put by me into a separate child node >>>> without putting address and size cells into. So I just moved it into >>>> /soc directly now and that seems to fixed the missing regulator. >>>> 2) The reset node is a allwinner,sun6i-a31-ahb1-reset, which does not >>>> get registered automatically, but by an explicit call from mach-sunxi/. >>>> I wonder why we do this (yes, I saw that comment, but still...) and if >>>> it would work with a normal MODULE_DEVICE_TABLE() declaration. >>>> There is and will be no equivalent to the mach- directory on arm64. >>> >>> On sun6i, we supported the high resolution timer, which had a reset control. >>> Timers (or clocksources) are registered before device model kicks in, so the >>> reset had to be explicitly registered before the timer, or the system would >>> hang. I think we phased that out though. Maxime should know. >> >> Ah, thanks for that insight! >> So that sounds like we would get away with a normal registration for the >> A64 - and actually many other SoCs as well? >> Shall we guard the explicit sun6i_reset_init with MACH_SUN6I or >> something and do the normal registration otherwise? >> Or do I miss something here? > > You'll notice 2 reset control compatibles, one is > "allwinner,sun6i-a31-ahb1-reset", > while the other is "allwinner,sun6i-a31-clock-reset". The latter is a > proper device > model driver. We also don't have the hstimer device node for later > SoCs. For A23, it > was because the hardware had only 1 timer, while the driver needed 2, > and I didn't > want to deal with it at the time. Oooh, now I see that those are actually the same driver, just the initialization part is separate. Thanks for the hint! > As long as you use "allwinner,sun6i-a31-clock-reset", no special code is needed. Yeah, great, I will just replace the string in the DT. Cheers, Andre. >> Cheers, >> Andre >> >>>> 3) As Jens pointed out, the MMC IP block isn't really compatible. >>>> Changing the clocks is easy (done already), but we need to come up with >>>> code to cover the new phase setting registers in the A64 MMC register block. >>>> >>>> Interestingly somehow hacking this (pretending it is compatible) seems >>>> to work, though I got reports from people about mysterious kernel >>>> crashes, so I'm inclined to leave MMC out of the first patch series. >>>> >>>> So if you could take a look at the new registers (starting at offset >>>> 0x140) and work out what we actually need to do here, that would be >>>> great. I have no real clue about what they actually do and how they >>>> relate to the current output and sample clock phase. >>>> To me it looks like we might get away with just triggering the automatic >>>> calibration and the hardware does the rest for us - keep your fingers >>>> crossed ;-) >>>> >>>> Cheers, >>>> Andre. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups "linux-sunxi" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@xxxxxxxxxxxxxxxx. >>>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups "linux-sunxi" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@xxxxxxxxxxxxxxxx. >> For more options, visit https://groups.google.com/d/optout. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
