On Thu, Nov 19, 2015 at 3:19 PM, Matthew McClintock <mmcclint@xxxxxxxxxxxxxxxx> wrote: > From: Varadarajan Narayanan <varada@xxxxxxxxxxxxxx> > > Add pinctrl driver support for IPQ4019 platform > > Signed-off-by: Sricharan R <sricharan@xxxxxxxxxxxxxx> > Signed-off-by: Mathieu Olivari <mathieu@xxxxxxxxxxxxxx> > Signed-off-by: Varadarajan Narayanan <varada@xxxxxxxxxxxxxx> > Signed-off-by: Matthew McClintock <mmcclint@xxxxxxxxxxxxxx> > --- I was asked to review this, to make sure that Linus wasn't waiting for my ack or anything. But now I see that you have not added him as a recipient. Please make sure to run ./scripts/get_maintainer.pl and pick appropriate recipients in the future. > > v3 > - update example with actual values from dts > - add missing pins 71-99 > - drop many functions and stick to basic functionality > I hope to see a patch later on adding all those functions back, but that's fine with me. [..] > +static struct platform_driver ipq4019_pinctrl_driver = { > + .driver = { > + .name = "ipq4019-pinctrl", > + .owner = THIS_MODULE, platform_drivers do get their .owner assigned by platform_drive_register(). > + .of_match_table = ipq4019_pinctrl_of_match, > + }, > + .probe = ipq4019_pinctrl_probe, > + .remove = msm_pinctrl_remove, > +}; Part of the .owner above you have my Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> @Linus, this still applies and builds cleanly on linux-next. Would you be okay dropping the owner assignment while applying this patch? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html