Hi Rob, On 2/12/2016 4:36 PM, Rob Herring wrote: > On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote: >> +Required properties: >> +- compatible : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1" >> + or "snps,ufshcd-2.0") > > History has taught us this needs to have a vendor specific compatible > string as well. Don't necessarily have to define it now, but just state > a vendor string is needed too. The compatibility string already as the "snps" which is the acronym for Synopsys which is the HW Controller vendor. Isn't this enough? > >> +- reg : <registers mapping> >> +- interrupts : <interrupt mapping for UFS host controller IRQ> >> + >> +Example: >> + ufs@0xd0000000 { >> + compatible = "snps,ufshcd-2.0"; >> + reg = < 0xd0000000 0x10000 >; >> + interrupts = < 24 >; >> + }; Thanks, Joao -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html