Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/04/2016 08:37 AM, Timur Tabi wrote:
Will Deacon wrote:
+static int sbsa_gwdt_keepalive(struct watchdog_device *wdd)
>+{
>+    struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd);
>+
>+    /*
>+    * Writing WRR for an explicit watchdog refresh.
>+    * You can write anyting(like 0xc0ffee).
>+    */
>+    writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR);
>+
>+    return 0;
>+}
You might get in trouble for that. 0xd09f00d is probably less poisonous.

http://www.petpoisonhelpline.com/poison/caffeine/

Any reason why we can't just keep it simple and write 0?

+1

Guenter

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux