Hi Arnd,
thanks for your feedback, please see my comments below.
On 04.02.2016 14:37, Arnd Bergmann wrote:
I would suggest you do the opposite and leave the id table in there
but change the first check to
if (IS_ENABLED(CONFIG_OF) && np)
So the compiler can discard that code when CONFIG_OF is disabled.
That's a good point!
+ pdev->dev.dma_mask = &da8xx_dmamask;
+ pdev->dev.coherent_dma_mask = da8xx_dmamask;
Don't hardcode DMA masks like this, the mask should be set to a 32-bit
mask whenever the device is created, and the driver can override it
by calling dma_set_mask().
You're right these two lines can be completely removed as a) they are
setting the wrong thing and b)
platform_device_register_full() already sets the correct dma mask from
the pinfo (in the original source file).
I will prepare a new patch.
Cheers
Petr
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
