On Thursday 04 February 2016 14:00:07 Petr Kulhavy wrote:
> @@ -560,6 +626,97 @@ static int da8xx_probe(struct platform_device *pdev)
> glue->dev = &pdev->dev;
> glue->clk = clk;
>
> + if (np) {
> + struct musb_hdrc_config *config;
> + struct musb_hdrc_platform_data *data;
> + u32 phy20_refclock_freq, phy20_clkmux_cfg;
> +
> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
> + if (!pdata) {
> + ret = -ENOMEM;
> + goto err5;
> + }
So all the code here is built unconditionally...
> @@ -627,11 +784,22 @@ static int da8xx_remove(struct platform_device *pdev)
> return 0;
> }
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id da8xx_id_table[] = {
> + {
> + .compatible = "ti,da8xx-musb"
> + },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, da8xx_id_table);
> +#endif
> +
but this is in an #ifdef?
I would suggest you do the opposite and leave the id table in there
but change the first check to
if (IS_ENABLED(CONFIG_OF) && np)
So the compiler can discard that code when CONFIG_OF is disabled.
> + pdev->dev.dma_mask = &da8xx_dmamask;
> + pdev->dev.coherent_dma_mask = da8xx_dmamask;
Don't hardcode DMA masks like this, the mask should be set to a 32-bit
mask whenever the device is created, and the driver can override it
by calling dma_set_mask().
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
